Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGBoost Photon HLT model files #14

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

smorovic
Copy link
Contributor

Initial version of XGBoost model files for XGBoost based Photon MVA for HLT.
Trained on XGBoost v1.7.5

For CMSSW PR:
cms-sw/cmssw#44473

Which will be updated accordingly to use these files by default and in an unit test.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic for branch master.

@smuzaffar, @aandvalenzuela, @iarspider, @cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@mmusich
Copy link

mmusich commented Mar 21, 2024

test parameters:

@mmusich
Copy link

mmusich commented Mar 21, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ba748/38316/summary.html
COMMIT: 75e26e9
CMSSW: CMSSW_14_1_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoEgamma-PhotonIdentification/14/38316/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ba748/38316/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ba748/38316/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
13045.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @rappoccio, @sextonkennedy: This PR was tested with cms-sw/cmssw#44473, please check if they should be merged together

@antoniovilela
Copy link

@smorovic @mandrenguyen @jfernan2
Please clarify if the model files are meant to be used only for HLT.
I ask @cms-sw/reconstruction-l2 to sign such that they are aware of the model files being included under RecoEgamma-PhotonIdentification

@smorovic
Copy link
Contributor Author

@antoniovilela
Yes, they are trained on photons and egamma variables reconstructed at HLT, so they are only applicable in this case.

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmssw#44500, please check if they should be merged together

@jfernan2
Copy link

+1

@antoniovilela
Copy link

+1

@antoniovilela
Copy link

antoniovilela commented Mar 22, 2024

merge

@cmsbuild cmsbuild merged commit 7375a6e into cms-data:master Mar 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants