-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of BDT based BH tagger training files #11
Conversation
A new Pull Request was created by @jainshilpi for branch master. @smuzaffar, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks. |
Pull request #11 was updated. |
note: probably the .xml.gz file should be removed, and this PR rebased to erase it from history and keep the git repo size minimal. |
@jainshilpi could you please rebase this PR to remove the .xml.gz from history? just to keep the size minimal |
Pull request #11 was updated. |
@jpata - sorry I meant to do it much before. Its done now. Thanks for the reminder. |
thanks, but this isn't fully correct: for the rebase, the commit history should contain only one commit, and it must be force pushed. Otherwise the deleted file still exists in git history. See here "overview of rebase" for more details: |
258a5e1
to
0705bf3
Compare
Pull request #11 was updated. |
I hope the last one takes care of removing this from the history as well. many thanks to @valsdav for helping with this. |
@cmsbuild please test with cms-sw/cmssw#36901 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc2ceb/22742/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
@perrotta @qliphy I think this needs to be merged since cms-sw/cmssw#36901 was merged |
or @smuzaffar it's currently stopping other PRs, see for example: |
+1 |
merge |
First commit of the training files needed by the PR #36901