-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Run3 electron MVA ID weight files from EGM POG #27
Conversation
A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for branch master. @smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9320c/29484/summary.html Comparison SummarySummary:
|
@cms-sw/reconstruction-l2 @cms-sw/orp-l2 Hi, can we get a go-ahead for this? This is needed for e/gamma IDs in 12_6. |
+1 |
@perrotta Just need your approval. :-) |
+1 |
Many runTheMatrix workflows are failing in CMSSW_13_0_X_2022-12-08-2300 because #40230 was merged but this one wasn't. I suppose the bot didn't merge the PR yet because of the |
+externals |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
I have merged this ( and cmsdist PR to update it in cmssw) now and restated an IB |
Thanks @smuzaffar ! Sorry, I should have pinged you yesterday to preempt the IB failures. |
Hi, @smuzaffar the IBs in 12_6 are broken looking for this, I think. Maybe I'm mistaken, but I thought this was decoupled from the CMSSW release? Do we need to make a separate 12_6 branch here? Thanks. |
@rappoccio , no we do not need 12.6.X branch here. We just need to backport the cmsdist PR cms-sw/cmsdist#8222 for 12.6.X. I will open it and merge it for next 12.6.X |
cms-sw/cmsdist#8225 is merged now for 12.6.X |
PR Description:
From EGM POG
Electron MVA IDs have been optimized for Run3.
The .root version of weight files have been added.