Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Run3 electron MVA ID weight files from EGM POG #27

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Prasant1993
Copy link
Contributor

PR Description:
From EGM POG
Electron MVA IDs have been optimized for Run3.
The .root version of weight files have been added.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2022

A new Pull Request was created by @Prasant1993 (Prasant Kumar Rout) for branch master.

@smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @valsdav, @lgray, @missirol, @sobhatta, @afiqaize, @wrtabb, @a-kapoor, @sameasy, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@rappoccio
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9320c/29484/summary.html
COMMIT: f132a26
CMSSW: CMSSW_13_0_X_2022-12-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoEgamma-ElectronIdentification/27/29484/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 11948 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421214
  • DQMHistoTests: Total failures: 6992
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3414188
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6.326 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -0.774 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): -0.454 KiB Physics/NanoAODDQM
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 46 workflows

@a-kapoor
Copy link

a-kapoor commented Dec 7, 2022

@cms-sw/reconstruction-l2 @cms-sw/orp-l2 Hi, can we get a go-ahead for this? This is needed for e/gamma IDs in 12_6.
Thanks.

@mandrenguyen
Copy link

+1

@a-kapoor
Copy link

a-kapoor commented Dec 7, 2022

@perrotta Just need your approval. :-)

@rappoccio
Copy link

+1

@makortel
Copy link

makortel commented Dec 9, 2022

Many runTheMatrix workflows are failing in CMSSW_13_0_X_2022-12-08-2300 because #40230 was merged but this one wasn't. I suppose the bot didn't merge the PR yet because of the externals-l2 signature is still missing (@smuzaffar @iarspider @aandvalenzuela).

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar
Copy link
Contributor

I have merged this ( and cmsdist PR to update it in cmssw) now and restated an IB

@rappoccio
Copy link

Thanks @smuzaffar ! Sorry, I should have pinged you yesterday to preempt the IB failures.

@rappoccio
Copy link

Hi, @smuzaffar the IBs in 12_6 are broken looking for this, I think. Maybe I'm mistaken, but I thought this was decoupled from the CMSSW release? Do we need to make a separate 12_6 branch here? Thanks.

@smuzaffar
Copy link
Contributor

@rappoccio , no we do not need 12.6.X branch here. We just need to backport the cmsdist PR cms-sw/cmsdist#8222 for 12.6.X. I will open it and merge it for next 12.6.X

@smuzaffar
Copy link
Contributor

cms-sw/cmsdist#8225 is merged now for 12.6.X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants