-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PartcileNet ONNX models for Run 3 PFScouting #49
Conversation
A new Pull Request was created by @alintulu (Adelina Lintuluoto) for branch master. @smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks. |
Hi, what is the status on this PR? We are ready to move on with the CMSSW PR (cms-sw/cmssw#40438), however it requires this PR to be merged first. |
@alintulu , these are all new files so should be OK to merge in to data repo. But lets first test with with the cmssw PR. I have started the tests for cms-sw/cmssw#40438 |
+reconstruction |
+1 |
as cms-sw/cmssw#40438 was merged, shouldn't this one be merged as well?
see log. Looks like |
+externals |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. |
cms-sw/cmsdist#8750 is merged and 11h IB should have the new data files |
Hi @smuzaffar! I tried running a module that access a file part of this PR, but it returned the following error message
I ran it in the IB release |
@alintulu , you need to wait for today's 11h IB i.e. CMSSW_13_3_X_2023-10-12-1100 (hopefully it will be available in 4 hours) |
Aaah sorry! I didn't make the connection with 11h, thank you! |
This PR adds the necessary files for running 3 types of inference for Run 3 PFScouting. The 3 models include
You can find plots over the performance of each model here.
We plan to redo the training for each model as soon as the improved Run 3 sample is ready (hopefully within a month). However as this PR is in combination with another to CMSSW adding a custom Run 3 PFScouting NanoAOD (cms-sw/cmssw#40438), we would like to include these first versions of the models already now.