Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined module wiring #5

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Conversation

aehart
Copy link
Contributor

@aehart aehart commented Jun 3, 2022

This PR introduces preliminary wiring files for the extended L1 tracking emulation with combined modules.

In particular, the TrackletProcessorDisplaced (TPD_*) replaces the TrackletEngineDisplaced (TED_*), TripletEngine (TRE_*), and TrackletCalculatorDisplaced (TPD_*). This configuration is not currently the default for the extended tracking, but is under development and will be needed for the eventual firmware to meet latency requirements.

@tomalin @skinnari @gershtein

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

A new Pull Request was created by @aehart (Andrew Hart) for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @erikbutz, @skinnari, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@epalencia
Copy link

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f821a/25248/summary.html
COMMIT: 8a97597
CMSSW: CMSSW_12_5_X_2022-06-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-TrackFindingTracklet/5/25248/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3651513
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3651483
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@aehart , all these are new data files. Is there any cmssw PR use these?

@tomalin
Copy link

tomalin commented Jun 10, 2022

@aehart , all these are new data files. Is there any cmssw PR use these?

We hope to make a cmssw PR today.

@cecilecaillol
Copy link

+l1

@rappoccio
Copy link

+1

@tomalin
Copy link

tomalin commented Nov 24, 2022

Dear all, this PR has been waiting for 5 months for no apparent reason. It is needed by the L1 tracking code. Can we merge it?

@perrotta
Copy link

please test
(last ones were quite some time ago)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f821a/29247/summary.html
COMMIT: 8a97597
CMSSW: CMSSW_12_6_X_2022-11-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackFindingTracklet/5/29247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417239
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3417205
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link

+1

@perrotta
Copy link

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants