Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files that have been removed in https://github.com/cms-sw/cmssw/pull/41279 #5

Merged
merged 1 commit into from
May 4, 2023

Conversation

aloeliger
Copy link
Contributor

This PR adds the model file and jecs root file in approximately the locations they were removed from in cms-sw/cmssw#41279

@thesps @slaurila @thomreis @cerminar @drankincms & @gpetruc: could you please confirm that you are okay with this arrangement in the data externals?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

A new Pull Request was created by @aloeliger (Andrew Loeliger) for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger, @cecilecaillol can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-532277/32152/summary.html
COMMIT: 7196760
CMSSW: CMSSW_13_1_X_2023-04-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1ParticleFlow/5/32152/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-532277/32152/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-532277/32152/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460685
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460663
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

+l1

@AdrianoDee
Copy link

+upgrade

@perrotta
Copy link

perrotta commented May 4, 2023

+1

  • Needed by #41279

@perrotta
Copy link

perrotta commented May 4, 2023

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants