Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PC LUTs for Run 3 2022 #23

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

eyigitba
Copy link
Contributor

New primitive conversion LUTs for EMTF.

The LUTs were deployed in firmware on October 6th 2022. These LUTs are necessary for the emulator to replicate firmware behaviour. I will make the relevant PRs to CMSSW shortly.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @eyigitba for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @JanFSchulte, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@epalencia
Copy link

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb4ef6/28426/summary.html
COMMIT: 26a2934
CMSSW: CMSSW_12_6_X_2022-10-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-L1TMuon/23/28426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3378384
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3378356
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link

+l1

@perrotta
Copy link

This has to go with #39822, which was already merged, and it is needed to read the data taken with the new primitive conversion LUTs in the EMTF emulator, whose firmware was deployed at P5 on October 6th

@eyigitba please confirm that this was tested together with #39822. and provide a few details about how that test was performed.

@perrotta
Copy link

merge
(they are just new files, anyhow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants