Add LUTs for CSC stub position offset and bending value. #1
Conversation
|
@smuzaffar, does @cmsbuild have to be updated so it can run tests on PRs for this repository? |
|
A new Pull Request was created by @dildick (Sven Dildick) for branch master. @smuzaffar, @benkrikler, @mrodozov, @cmsbuild, @rekovic, @tulamor can you please review it and eventually sign? Thanks. |
|
@dildick , cmsbuild already knows how to test. Please make sure to update cmssw to make use of these new files. Once you have a cmssw PR then you can comment "please test with ms-data/L1Trigger-CSCTriggerPrimitives#1" to start the tests |
|
@smuzaffar That is great to hear. I am working on a pull request to use the new LUTs in the trigger. |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 79d9738 CMSSW: CMSSW_11_2_X_2020-06-10-2300 I found follow errors while testing this PR Failed tests: Build HeaderConsistency ClangBuild
I found compilation error when building: ^~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pythia8/302-db6b9d/include/Pythia8/Weights.h:140:7: warning: 'class Pythia8::WeightsLHEF' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] >> Building shared library tmp/slc7_amd64_gcc820/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -ldire /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lvincia collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc820/src/FastSimulation/ParticleDecay/src/FastSimulationParticleDecay/libFastSimulationParticleDecay.so] Error 1 Leaving library rule at FastSimulation/ParticleDecay Entering library rule at src/FastSimulation/ParticleDecay/plugins >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/FastSimulation/ParticleDecay/plugins/TestPythiaDecays.cc In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/pythia8/302-db6b9d/include/Pythia8/Info.h:17,
I found compilation error while trying to compile with clang. Command used: ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/Py8JetGun.cc:5:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8GunBase.h:21:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8InterfaceBase.h:15:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/dire/2.004-bcolbf2/include/Dire/Dire.h:10:
/cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/external/dire/2.004-bcolbf2/include/Dire/DireTimes.h:198:25: error: assigning to 'Pythia8::Info *' from incompatible type 'const Pythia8::Info *'
infoPtr = &pythiaPtr->info;
^~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/plugins/Py8PtotGun.cc:4:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8GunBase.h:21:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-10-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8InterfaceBase.h:15:
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
The tests are being triggered in jenkins. |
|
Comparison is ready Comparison Summary:
|
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+externals |
|
merge |
Fixed merging issues, headers, lowered fit stat requirements
preliminary reduction and renaming of tables
This repository holds look-up-tables which, in their current form, map a 12-bit comparator code onto a floating point number. That can either be a position offset or a slope. In the current form, there are 5 patterns (0 through 4) and 4096 comparator codes. For the position offset, there is an ideal case and a realistic case. The ideal case does not take into account a global offset from alignment effects, while the realistic case does. In future versions, the values in the look-up-tables will be translated from floating point to unsigned int.