-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UL pixel resolution histograms for all years #4
Conversation
A new Pull Request was created by @lcorcodilos for branch master. @smuzaffar, @civanch, @lveldere, @iarspider, @mdhildreth, @mrodozov, @cmsbuild, @ssekmen, @sbein can you please review it and eventually sign? Thanks. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8413e2/17538/summary.html Comparison SummarySummary:
|
please test with cms-sw/cmssw#34812 |
-1 Failed Tests: RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelValsRelVals-INPUTAddOn Tests
Expand to see more addon errors ...
|
please test with cms-sw/cmssw#34812 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8413e2/22634/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummaryThe workflows 1001.0, 1000.0, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
+externals |
closing this as cms-sw/cmssw#34812 ( which requires it) is closed too. Open a new PR if needed |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8413e2/35770/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
These additional pixel resolution histogram files will eventually be used by a new UL config akin to PixelPluginsPhase1_cfi.py. I'll be making a separate PR later today or tomorrow to cmssw for this change. However, this config will be "off" by default because UL FastSim production has already begun. These data files should nonetheless be preserved here and there will be an ability to turn them "on" in the cmssw block of code for future studies or private production.
Among the ROOT files, I've also included a txt file that explain the numerical codes at the end of each file name. This information explains to what part of the detector the file maps (year/detector layer) and from which PIXELAV template files the resolution were generated ("Files").
@pmaksim1 @OzAmram @tvami