Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTV developments. C_tt_workflow & QCD_soft_mu workflow. QCD studies #101

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

ValVau
Copy link
Contributor

@ValVau ValVau commented Oct 15, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

-scripts:Added 2D_plotter and a correlation plot maker used in the QCD studies
-utils: added to AK4_parameters LSF for 22, 23; new hists for QCD smu wf and ttsemilep_valid_sf
-helpers: update_branch fixed ProbC, added definitions_for_corr
-workflows: added new workflows ttsemilep_valid_sf (additional c selection) and QCD soft muon wf
Copy link
Collaborator

@Ming-Yan Ming-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ValVau thanks for the PR!

I have some comments and questions following by lines, could you please have a look?
Thanks!

scripts/2Dhistograms.py Show resolved Hide resolved
scripts/2Dhistograms.py Show resolved Hide resolved
scripts/correlation_plots.py Show resolved Hide resolved
scripts/correlation_plots.py Show resolved Hide resolved
src/BTVNanoCommissioning/helpers/definitions_for_corr.py Outdated Show resolved Hide resolved
@@ -409,6 +415,7 @@ def load_data(
event_counts.append((key, len(df))) # Store the number of events and the key

# Define ranking factors for each subfolder
###FIXME: sumw has to change, whenever you run a different set. Pay attention!!!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please comment it the former is xs and later is sumw ?

@@ -399,6 +406,7 @@ def load_data(
event_counts.append((key, len(df))) # Store the number of events and the key

# Define ranking factors for each subfolder
###FIXME: sumw has to change, whenever you run a different set. Pay attention!!!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please comment it the former is xs and later is sumw ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also elaborate what is the ranking factor, I think it's to derived the yields, would be good to clarify

Copy link
Collaborator

@Ming-Yan Ming-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ValVau thank you so much for the updates, only two minor points I would like to clarify in your code, could you please add some info there? Thank you!

Copy link
Collaborator

@Ming-Yan Ming-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @ValVau thanks for clarification, the WF are good to merge.

@Ming-Yan Ming-Yan merged commit cdb64f9 into cms-btv-pog:master Oct 22, 2024
9 checks passed
@uttiyasarkar uttiyasarkar mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants