Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating 2018 GTs from PPD latest recommendations #1201

Merged

Conversation

panwarlsweet
Copy link
Contributor

Dear Simone,

I am making this PR to update the 2018 GTs according to the latest PPD recommendation. But before you merge I need to clear a few points.

  1. For 2018 Data, GTs work perfectly.
  2. For 2018 MC, the v20 2018 shows the error [1] when I try to run on 2018 mircoAODs so, for now, I have kept it v19 (from link [2], it shows that only uncertainty changes between v19 and v20 mc tag, central values are same).

The problem with v20 also was reported at [3] in December so I preferred to stick with v19. If you find that v19 is good then GTs are correct but if we need to go with v20 then could you please help me fix the error?

Thanks,
Lata

[1] Begin processing the 1st record. Run 1, Event 604005, LumiSection 605 on stream 0 at 15-Feb-2020 09:08:22.547 CET
----- Begin Fatal Exception 15-Feb-2020 09:09:08 CET-----------------------
An exception of category 'NotFound' occurred while
[0] Processing Event run: 1 lumi: 605 event: 604005 stream: 0
[1] Running path 'p'
[2] Calling method for module FlashggJetSystematicProducer/'flashggJetSystematics0'
Exception Message:
JER parametrisation depends on 'JetPt' but no value for this parameter has been specified. Please call the appropriate 'set' function of the JME::JetParameters object
----- End Fatal Exception -------------------------------------------------

[2] https://hypernews.cern.ch/HyperNews/CMS/get/jes/898.html

[3] https://hypernews.cern.ch/HyperNews/CMS/get/jes/933.html

@simonepigazzini
Copy link
Contributor

Hello @panwarlsweet, we will keep v19 for the moment. Have you tried to follow the instructions you can find in the twiki liked to the HN thread you mentioned?

Best,

simone

@simonepigazzini simonepigazzini merged commit 784c6de into cms-analysis:dev_legacy_runII Feb 24, 2020
@panwarlsweet
Copy link
Contributor Author

Hello @simonepigazzini

I read all the HN posts related to this and when I read the comment at [1], it says that it should work for all the release afterward CMSSW_10_2_18. Since we are using 10_5_0, I expected that it would work fine but it didn't.

[1] https://hypernews.cern.ch/HyperNews/CMS/get/jes/898/2/1/1/1/1/1/1/1/1.html

sam-may pushed a commit to sam-may/flashgg that referenced this pull request May 22, 2020
sam-may pushed a commit to sam-may/flashgg that referenced this pull request May 29, 2020
wamorkart pushed a commit to wamorkart/flashgg that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants