Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial framework setup #1

Merged
merged 4 commits into from
May 29, 2014
Merged

Initial framework setup #1

merged 4 commits into from
May 29, 2014

Conversation

sethzenz
Copy link
Contributor

Completely redid the repository structure. Have primitive objects and producers. Will send email to list.

sethzenz added a commit that referenced this pull request May 29, 2014
Initial framework setup
@sethzenz sethzenz merged commit bd55da3 into cms-analysis:master May 29, 2014
@bendavid
Copy link

Hi Seth,
I just want to clarify a point about this.

The way I understand it, if CompositeCandidate is used, then the CompositeCandidate "owns" the photon daughters. Meaning they are stored INSIDE the composite candidate and NOT in a seperate collection.

This is probably fine, because the photons will always have specific properties modified (the four vector at least) such that they are only relevant with respect to a particular diphoton object. But it should be clearly understood that this is the case.

@bendavid
Copy link

(The alternative would be CompositeRefCandidate or CompositeRefCandidateT, where the photons get stored in a seperate collection and referenced by the diphoton object)

@sethzenz
Copy link
Contributor Author

Hmm. I am not sure this is what we want, esp. since the vertex is not a daughter so the behavior would not be uniform. I think we can leave it for now and give it another think at the point when it starts to matter. Thanks for pointing this out.

@bendavid
Copy link

The vertex is different in the sense that two diphoton objects may point to the same vertex. But yes, I agree there may be another reason to do this differently, let's think about it a bit.

@bendavid
Copy link

I think the other implication of this is that if CompositeCandidate is used, then the photon collection should NOT be kept in the output, because it becomes only intermediate. (The "real" photons live inside the diphoton objects in the diphoton collection at that point)

@sethzenz
Copy link
Contributor Author

That aspect of it is actually appealing, at least if any of the photon properties might be changed based on the diphoton+vertex interpretation. In fact, I think the answer to that question might determine whether we CompositeCandidate or CompositeRefCandidate.

pmeridian pushed a commit to pmeridian/flashgg that referenced this pull request Feb 2, 2016
ldcorpe pushed a commit that referenced this pull request Apr 11, 2016
initial moving of final fit folders to new repo
sethzenz referenced this pull request in sethzenz/flashgg Jun 7, 2016
adding test correction files for 2016B
edjtscott referenced this pull request in edjtscott/flashgg Aug 10, 2016
fravera pushed a commit to fravera/flashgg that referenced this pull request Sep 20, 2016
gkrintir pushed a commit to gkrintir/flashgg-1 that referenced this pull request Feb 9, 2017
nadya-chernyavskaya referenced this pull request in nadya-chernyavskaya/flashgg Jul 17, 2018
thongonary pushed a commit to thongonary/flashgg that referenced this pull request Nov 1, 2018
…rkspaces

cleanup double-H setup and turn on HH categorization
bmarzocc pushed a commit to bmarzocc/flashgg that referenced this pull request Jul 3, 2019
edjtscott referenced this pull request in edjtscott/flashgg Feb 7, 2020
gbyu referenced this pull request in gbyu/flashgg Apr 14, 2020
jonathon-langford pushed a commit to jonathon-langford/flashgg that referenced this pull request Sep 23, 2020
…Sstage1p2_FullWorkflow

Include the VHMet Tag
youyingli pushed a commit that referenced this pull request Nov 3, 2020
youyingli pushed a commit that referenced this pull request Jan 19, 2021
youyingli pushed a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants