forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTC_merge2 branch updated to 1130 #74
Merged
Merged
Changes from 35 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
67f080b
Anders DTC merge with a gazillion manual fixes
skinnari 8e775d1
propagate buildfile fixes
skinnari 650ff58
code formats
skinnari b140ffe
fix cherrypick mess up
skinnari 04d9dfa
Remove LayerProjection class
549ac30
Further cleanup of tracklet projections interface
e647457
Correct number of processing steps by changing < to <=
aryd b51b039
Add missing include of algorithm
aryd cf5498d
Remove extra const
aryd 1bf7df1
Remove some commented out code
936da8a
Remove duplicate code
314eb77
Fix message logger and DTC Stub for consistency with hybrid configura…
aryd 0371772
Fix problem with writing of input link memories
c9c646a
Create Residual class that will replace LayerResidual and DiskResidual
da78939
Remove the use of the class DiskResiduals
5f76609
Remove unused nMatch and nMatchDisk method of Tracklet
a181be9
(Re-)Implement the correction to writing the DTC data link file after…
946b120
Combine addMatch method for disk and layers into on method
4c6a774
combine the disk and layer match into one method
6255829
Remove some redundant poiters to l1tstubs
c19d68d
Pass iSeed to Tracklet
52d12b8
Introduce an InputRouter module. Does not change functionality, but s…
023c439
Cleanup of writing the DTC link files
00a8a23
Change processing order such that all steps in one sector are done an…
f4109cc
Interface updates for CMSSW following change to module processing order
aryd bd26658
Change in VMRouter to processing PS links before 2S in disks
c7487ed
Merge changes
d4d39b7
Cleanup of unused iSector variable in processs and memory modules
44ea72e
Fixes to make the HybridTracks_cfg.py run
aryd 6d8b6f8
Cleanup of hardcoded numbers etc.
3124072
Merge branch 'DTC_merge_1130' of github.com:cms-l1tk/cmssw into DTC_m…
a40f339
Updates to MP to put all regions into one memory slot in the Projecti…
ed2269e
Fix to calculation of irinv for projections - no matches what is done…
271ec43
Remove now unused file paths for the old cable mapping code
be7420e
Correct missplaced curly bracket
c90b216
Fixes for the displaced tracking
b26fc19
Fix to avoid duplicate VMSTE name in D1 for standard configuration
576bda0
Address comments from Louise S.
de0f887
Ran scram b code-format
aryd 2a823e0
Address comments from Louise S.
64cd602
Addressing more comments from Louise S.
cc9e791
More fixes to comments
e164c32
Make running hybrid default (not displaced)
aryd 0c972b5
restore buildfile
skinnari 35928d1
Add DTC link config to Settings.h
e8618ed
Merge branch 'DTC_merge_1130' of github.com:cms-l1tk/cmssw into DTC_m…
adcfecf
Changes to suppress warning in MatchCalculator when running displaced…
d51d818
Fix typo introduced in code cleanup for MatchProcessor
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
L1Trigger/TrackFindingTracklet/interface/AllInnerStubsMemory.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#ifndef L1Trigger_TrackFindingTracklet_interface_AllInnerStubsMemory_h | ||
#define L1Trigger_TrackFindingTracklet_interface_AllInnerStubsMemory_h | ||
|
||
#include "L1Trigger/TrackFindingTracklet/interface/MemoryBase.h" | ||
|
||
#include <utility> | ||
#include <string> | ||
#include <vector> | ||
|
||
namespace trklet { | ||
|
||
class Settings; | ||
class Stub; | ||
class L1TStub; | ||
|
||
class AllInnerStubsMemory : public MemoryBase { | ||
public: | ||
AllInnerStubsMemory(std::string name, Settings const& settings); | ||
|
||
~AllInnerStubsMemory() override = default; | ||
|
||
void addStub(const Stub* stub) { stubs_.push_back(stub); } | ||
|
||
unsigned int nStubs() const { return stubs_.size(); } | ||
|
||
const Stub* getStub(unsigned int i) const { return stubs_[i]; } | ||
|
||
void clean() override { stubs_.clear(); } | ||
|
||
void writeStubs(bool first, unsigned int iSector); | ||
|
||
private: | ||
std::vector<const Stub*> stubs_; | ||
}; | ||
|
||
}; // namespace trklet | ||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// This class holds a list of stubs for an DTC link. | ||
// This modules 'owns' the pointers to the stubs. All subsequent modules that handles stubs uses a pointer to the original stored here. | ||
#ifndef L1Trigger_TrackFindingTracklet_interface_DTCLinkMemory_h | ||
#define L1Trigger_TrackFindingTracklet_interface_DTCLinkMemory_h | ||
|
||
#include "L1Trigger/TrackFindingTracklet/interface/MemoryBase.h" | ||
|
||
#include <vector> | ||
|
||
namespace trklet { | ||
|
||
class Settings; | ||
class Globals; | ||
class Stub; | ||
class L1TStub; | ||
|
||
class DTCLinkMemory : public MemoryBase { | ||
public: | ||
DTCLinkMemory(std::string name, Settings const& settings, double, double); | ||
|
||
~DTCLinkMemory() override = default; | ||
|
||
void addStub(const L1TStub& al1stub, const Stub& stub); | ||
|
||
unsigned int nStubs() const { return stubs_.size(); } | ||
|
||
Stub* getStub(unsigned int i) { return stubs_[i]; } | ||
|
||
void writeStubs(bool first, unsigned int iSector); | ||
|
||
void clean() override; | ||
|
||
private: | ||
std::vector<Stub*> stubs_; | ||
}; | ||
|
||
}; // namespace trklet | ||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment for "nearfull" is identical to that of "almostfull" - can they be made more meaningful to distinguish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed comment.