Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all methods' return values uniform #11

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

nothingface0
Copy link
Contributor

@nothingface0 nothingface0 commented Oct 22, 2024

  • [Breaking change] Basically all runregistry methods, instead of returning request.Response, will now try to parse them, run json() and return a dict, or list of dicts. Exceptions are now raised in case of insufficient permissions. Previously, the return values were different for each method, others being request.Response (or lists of those), dicts, or lists of dicts.
  • Added codecov for test coverage.
  • Added several tests for extending test coverage.

Basically instead of responses, the package will now
try to parse the response, run json() and return a dict,
or list of dicts. Exceptions are now raised in case of
insufficient permissions.
@nothingface0 nothingface0 changed the title Add codecov to tests Make all methods' return values uniform Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@nothingface0 nothingface0 force-pushed the uniform_return_values branch from b1886ae to 8ec4ac4 Compare October 22, 2024 15:14
Invalid inputs usually raise a ValueError, AFAIK.
Generic Exceptions are kept for permission errors.

TODO: Maybe create a custom Exception for the
latter case.
@nothingface0 nothingface0 merged commit 37e9f90 into dev Oct 24, 2024
6 checks passed
@nothingface0 nothingface0 deleted the uniform_return_values branch November 6, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant