fix: filterReq crashes send middleware

[langtutheky]

Issue

fix: filterReq crashes send middleware

Details

When filterReq return false, the middleware will crash with this error after it attempts to call next to static serving middleware such as send

error: Uncaught Error: The response is not writable.
throw new Error("The response is not writable.");

Must return the promise yield by next when invoking from within a promise chain. This is similar to Getting "The response is not writable."

CheckList

• PR starts with [#ISSUE_ID].
• Has been tested (where required) before merge to main.

[cmorten]

Hi @langtutheky 👋 thanks for the fix!

I was wondering if you would be able to add a test for this to https://github.com/asos-craigmorten/oak-http-proxy/blob/main/test/filterReq.test.ts ?

There are already cases for when false is returned so be interesting to see what is required to make this error!

[langtutheky]

@cmorten You are welcome, this is actually a major design problem/bug from Oak. I will let them know later but just keep in mind that for now, all call to next must directly participate in the middleware chain through either return or await.

[cmorten]

@langtutheky tests look good - just need to run make fmt to fix some formatting issues

[asos-craigmorten]

Looks good, the issue now I believe is conflicting std lib versions, potentially because of the upgrade of Oak. We can either downgrade Oak back to 7.3.0 to try and get this out, or update the various versions ( in this or another PR - leaning towards getting something separate raised and merged ).

[langtutheky]

I think you should make another PR to upgrade Oak to 7.7.0, there was a type error while running test with 7.3.0 which is why I upgraded. I can only run 7.3.0 with --no-check flag, which is not ideal.