Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing icon and fixing AppBar bug #22

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Removing icon and fixing AppBar bug #22

merged 1 commit into from
Dec 26, 2020

Conversation

cmorigaki
Copy link
Owner

Context

  • Removing icon from Recipe details and fixing AppBar "bug": lock expansion if no screen header image was loaded

Code

  • Removing recipe_detail_item_image view
  • Create extension AppBarLayout.setCollapsedAndDisableScroll

Additional notes

Before After
image image
recipe-toolbar-bug recipe_toolbar_fix

@cmorigaki cmorigaki added bug Something isn't working enhancement New feature or request labels Dec 26, 2020
@cmorigaki cmorigaki self-assigned this Dec 26, 2020
@cmorigaki cmorigaki merged commit d34392f into main Dec 26, 2020
@cmorigaki cmorigaki deleted the removing-icon-fixing-appbar-bug branch December 26, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmorigaki cmorigaki

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmorigaki