Including version info into Settings screen (#26)

## Context - In order to help users identify the app version, we're including this information on the footer of the Settings screen ## Code - Add `TextView`, `StateFlow` and get the information from `BuildConfiguration` - gradle/kotlin update ## Additional notes <img src="https://user-images.githubusercontent.com/38049362/107878120-520f5200-6eaf-11eb-9877-ec273af7aa5d.png" width=300/>
cmorigaki · Feb 14, 2021 · 6fe37b7 · 6fe37b7
1 parent 56aef8e
commit 6fe37b7
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 7 deletions.
diff --git a/build.gradle b/build.gradle
@@ -17,8 +17,8 @@ buildscript {
         jcenter()
     }
     ext {
-        kotlinVersion = "1.4.21"
-        gradleVersion = "4.1.1"
+        kotlinVersion = "1.4.30"
+        gradleVersion = '4.1.2'
     }
 
     dependencies {

diff --git a/features/settings/build.gradle b/features/settings/build.gradle
@@ -6,4 +6,5 @@ dependencies {
     implementation AndroidLibConfig.material
 
     implementation project(ProjectConfig.analytics)
+    implementation project(ProjectConfig.configuration)
 }
diff --git a/features/settings/src/main/java/br/com/recipebook/settings/di/SettingsModule.kt b/features/settings/src/main/java/br/com/recipebook/settings/di/SettingsModule.kt
@@ -21,7 +21,8 @@ val settingsPresentationModule = module {
         SettingsViewModel(
             viewState = SettingsViewState(),
             getSettingsList = get(),
-            analytics = get()
+            analytics = get(),
+            buildConfiguration = get(),
         )
     }
 }

diff --git a/features/settings/src/main/java/br/com/recipebook/settings/presentation/SettingsViewModel.kt b/features/settings/src/main/java/br/com/recipebook/settings/presentation/SettingsViewModel.kt
@@ -2,6 +2,7 @@ package br.com.recipebook.settings.presentation
 
 import androidx.lifecycle.viewModelScope
 import br.com.recipebook.analytics.Analytics
+import br.com.recipebook.di.BuildConfiguration
 import br.com.recipebook.settings.analytics.ViewSettingsEvent
 import br.com.recipebook.settings.domain.model.SettingsItemModel
 import br.com.recipebook.settings.domain.usecase.GetSettingsUseCase
@@ -15,10 +16,12 @@ import kotlinx.coroutines.launch
 class SettingsViewModel(
     override val viewState: SettingsViewState,
     private val getSettingsList: GetSettingsUseCase,
-    private val analytics: Analytics
+    private val analytics: Analytics,
+    buildConfiguration: BuildConfiguration,
 ) : BaseViewModel<SettingsViewState, SettingsAction, SettingsCommand>() {
 
     init {
+        viewState.appVersion.value = buildConfiguration.appInfo.version
         viewModelScope.launch {
             setLoadingState()
             getSettingsList().mapSuccess(::onLoadSuccess).mapError(::onLoadError)

diff --git a/features/settings/src/main/java/br/com/recipebook/settings/presentation/SettingsViewState.kt b/features/settings/src/main/java/br/com/recipebook/settings/presentation/SettingsViewState.kt
@@ -11,4 +11,5 @@ class SettingsViewState {
     val hasError = MutableStateFlow(false)
 
     val listItems = MutableStateFlow<List<SettingsItem>>(emptyList())
+    val appVersion = MutableStateFlow("")
 }
diff --git a/features/settings/src/main/java/br/com/recipebook/settings/view/SettingsActivity.kt b/features/settings/src/main/java/br/com/recipebook/settings/view/SettingsActivity.kt
@@ -74,6 +74,12 @@ class SettingsActivity : AppCompatActivity() {
                 adapter.setData(it)
             }
         }
+
+        lifecycleScope.launchWhenStarted {
+            viewModel.viewState.appVersion.collect {
+                if (it.isNotBlank()) binding.appVersion.text = getString(R.string.settings_app_version, it)
+            }
+        }
     }
 
     private fun observeActionCommand() {

diff --git a/features/settings/src/main/res/layout/settings_activity.xml b/features/settings/src/main/res/layout/settings_activity.xml
@@ -34,6 +34,15 @@
 
     </androidx.recyclerview.widget.RecyclerView>
 
+    <TextView
+        android:id="@+id/app_version"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        app:layout_constraintBottom_toBottomOf="parent"
+        android:layout_margin="@dimen/margin_normal_100"
+        app:layout_constraintEnd_toEndOf="parent"
+        tools:text="Version 1.0.0"/>
+
     <include
         android:id="@+id/settings_error_state"
         layout="@layout/error_state_view"

diff --git a/features/settings/src/main/res/values-pt/settings_strings.xml b/features/settings/src/main/res/values-pt/settings_strings.xml
@@ -2,4 +2,5 @@
 <resources>
     <string name="settings_title">Configurações</string>
     <string name="settings_theme">Alterar tema</string>
+    <string name="settings_app_version">Versão %s</string>
 </resources>
diff --git a/features/settings/src/main/res/values/settings_strings.xml b/features/settings/src/main/res/values/settings_strings.xml
@@ -2,4 +2,5 @@
 <resources>
     <string name="settings_title">Configuration</string>
     <string name="settings_theme">Change theme</string>
+    <string name="settings_app_version">Version %s</string>
 </resources>
diff --git a/project-config/dependencies.gradle b/project-config/dependencies.gradle
@@ -14,10 +14,10 @@ ext {
         versionCode: 2,
         versionName: "0.1.0",
 
-        compileSdk: 29,
-        buildTools: "29.0.3",
+        compileSdk: 30,
+        buildTools: "30.0.3",
         minSdk: 23,
-        targetSdk: 29
+        targetSdk: 30
     ]
 
     AndroidLibConfig = [