-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surface wetting module #96
Conversation
for more information, see https://pre-commit.ci
Add initial classes for surface wetting module
`Graphene` now inherits from `Molecule`
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 93.87% 94.02% +0.15%
==========================================
Files 20 23 +3
Lines 1550 1724 +174
==========================================
+ Hits 1455 1621 +166
- Misses 95 103 +8
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The tutorial looks good! Just one suggestion, I think we should try to use the same formatting we have in pre-commit in the tutorial code snippets. For example:
Should become
I think it is easier to read and following along this way. |
This is still a work in progress, but begins a surface wetting module that we've discussed before. We can use this as a place to discuss the design choices we'll have to make.