Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mBuild's periodic polymer bonding #148

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

chrisjonesBSU
Copy link
Member

The polymer builder in mBuild now lets you form periodic bonds, which basically just means you can bond the head and tail ports together. This should be useful for simulating polymer lattices where we want bonds formed across the the chain length direction.

This PR adds an option to the Polymer class that lets you use this built in feature in mBuild

Copy link
Collaborator

@marjanalbooyeh marjanalbooyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you Chris.
I just added two minor comments.

flowermd/base/molecule.py Outdated Show resolved Hide resolved
flowermd/base/molecule.py Show resolved Hide resolved
@chrisjonesBSU chrisjonesBSU merged commit a8c9d8d into main Jul 9, 2024
10 checks passed
@chrisjonesBSU chrisjonesBSU deleted the periodic-polymers branch July 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants