Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some comments #6

Open
wants to merge 1 commit into
base: unclean_config
Choose a base branch
from
Open

Address some comments #6

wants to merge 1 commit into from

Conversation

dielhennr
Copy link

@dielhennr dielhennr commented Jul 28, 2021 •
edited
Loading

Addressed some on Jun's comments a while ago.

  1. Use Optional<Boolean>
  2. remove toList method
  3. Add FenceBrokerRecord before PartitionChangeRecord in handleBrokerFenced

This PR is stacked on apache#10463

@dielhennr dielhennr mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dielhennr