Rename unexported isgreater in reduceddim

cmcaine · Mar 30, 2020 · f6a2e73 · f6a2e73
1 parent b6c06dd
commit f6a2e73
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/base/reducedim.jl b/base/reducedim.jl
@@ -780,7 +780,7 @@ function _findmin(A, region)
     end
 end
 
-isgreater(a, b) = isless(b,a)
+_isgreater(a, b) = isless(b,a)
 
 """
     findmax!(rval, rind, A) -> (maxval, index)
@@ -791,7 +791,7 @@ dimensions of `rval` and `rind`, and store the results in `rval` and `rind`.
 """
 function findmax!(rval::AbstractArray, rind::AbstractArray, A::AbstractArray;
                   init::Bool=true)
-    findminmax!(isgreater, init && !isempty(A) ? fill!(rval, first(A)) : rval, fill!(rind,zero(eltype(keys(A)))), A)
+    findminmax!(_isgreater, init && !isempty(A) ? fill!(rval, first(A)) : rval, fill!(rind,zero(eltype(keys(A)))), A)
 end
 
 """
@@ -824,7 +824,7 @@ function _findmax(A, region)
         end
         similar(A, ri), zeros(eltype(keys(A)), ri)
     else
-        findminmax!(isgreater, fill!(similar(A, ri), first(A)),
+        findminmax!(_isgreater, fill!(similar(A, ri), first(A)),
                     zeros(eltype(keys(A)), ri), A)
     end
 end