Skip to content

Commit

Permalink
Aura: Remove double stacking line causing issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@killerwife
killerwife committed Sep 28, 2023
1 parent c1c7ae2 commit 636dfb0
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/game/Spells/SpellAuras.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,6 @@ Aura::Aura(SpellEntry const* spellproto, SpellEffectIndex eff, int32 const* curr
damage = OnAuraValueCalculate(caster, damage);
}

damage *= holder->GetStackAmount();

DEBUG_FILTER_LOG(LOG_FILTER_SPELL_CAST, "Aura: construct Spellid : %u, Aura : %u Target : %d Damage : %d", spellproto->Id, spellproto->EffectApplyAuraName[eff], spellproto->EffectImplicitTargetA[eff], damage);

SetModifier(AuraType(spellproto->EffectApplyAuraName[eff]), damage, spellproto->EffectAmplitude[eff], spellproto->EffectMiscValue[eff]);
Expand Down

6 comments on commit 636dfb0

@cpevors
Copy link

@cpevors cpevors commented on 636dfb0 Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't fix compilation for me. I still get a FAILED due to duplicate line when I install my Database.

image

@Muehe
Copy link
Contributor

@Muehe Muehe commented on 636dfb0 Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpevors That's not compilation though. And there isn't a spell with entry 17 on line 1061 of the spell.sql for any expansion as far as I can see... Seems like something broke on your end.

@cpevors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rebuilt WotLK from scratch, but let me try again.

@kelbren
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is caused by this commit : 2d805e0#diff-2e82349bd8b2dce7e5dadf3cd4acbec093ac5940588f7e414171c3e904d0e185

@Muehe
Copy link
Contributor

@Muehe Muehe commented on 636dfb0 Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6c7edc5

@cpevors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to buy a coffee or something.

Please sign in to comment.