Sholazar: Fix assignment of proper entry for q.12726

cmangos · Oct 8, 2023 · 4ecf01a · 4ecf01a
1 parent a4bb6fc
commit 4ecf01a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 9 deletions.
diff --git a/sql/scriptdev2/spell.sql b/sql/scriptdev2/spell.sql
@@ -813,7 +813,6 @@ INSERT INTO spell_scripts(Id, ScriptName) VALUES
 (52812,'spell_molten_fury_flamebringer'),
 (52862,'spell_devour_wind'),
 (52864,'spell_devour_water'),
-(52866,'spell_transform_visual'),
 (52942,'spell_pulsing_shockwave'),
 (53031,'spell_crusader_parachute'),
 (53032,'spell_flurry_of_claws'),

diff --git a/src/game/AI/ScriptDevAI/scripts/northrend/sholazar_basin.cpp b/src/game/AI/ScriptDevAI/scripts/northrend/sholazar_basin.cpp
@@ -719,6 +719,22 @@ struct DevourWind : public SpellScript
 
         return SPELL_CAST_OK;
     }
+
+    void OnCast(Spell* spell) const override
+    {
+        // transform visual
+        spell->GetCaster()->CastSpell(nullptr, 52866, TRIGGERED_OLD_TRIGGERED);
+
+        if (!spell->GetCaster()->IsCreature())
+            return;
+
+        // change into water
+        Creature* caster = static_cast<Creature*>(spell->GetCaster());
+        caster->UpdateEntry(28985);
+        caster->GetCharmInfo()->InitVehicleCreateSpells();
+        if (Player* player = dynamic_cast<Player*>(caster->GetCharmer()))
+            player->VehicleSpellInitialize();
+    }
 };
 
 // 52864 - Devour Water
@@ -735,19 +751,18 @@ struct DevourWater : public SpellScript
 
         return SPELL_CAST_OK;
     }
-};
 
-// 52866 - Transform Visual
-struct TransformVisual : public SpellScript
-{
-    void OnEffectExecute(Spell* spell, SpellEffectIndex /*effIdx*/) const override
+    void OnCast(Spell* spell) const override
     {
+        // transform visual
+        spell->GetCaster()->CastSpell(nullptr, 52866, TRIGGERED_OLD_TRIGGERED);
+
         if (!spell->GetCaster()->IsCreature())
             return;
 
+        // change into water
         Creature* caster = static_cast<Creature*>(spell->GetCaster());
-        caster->UpdateEntry(spell->GetCaster()->GetEntry() == 28985 ? 28999 : 28985);
-        caster->SetSpellList(spell->GetCaster()->GetEntry() * 100 + 1);
+        caster->UpdateEntry(28999);
         caster->GetCharmInfo()->InitVehicleCreateSpells();
         if (Player* player = dynamic_cast<Player*>(caster->GetCharmer()))
             player->VehicleSpellInitialize();
@@ -806,6 +821,5 @@ void AddSC_sholazar_basin()
     RegisterSpellScript<SummonSooholu>("spell_summon_sooholu");
     RegisterSpellScript<DevourWind>("spell_devour_wind");
     RegisterSpellScript<DevourWater>("spell_devour_water");
-    RegisterSpellScript<TransformVisual>("spell_transform_visual");
     RegisterSpellScript<FlurryOfClaws>("spell_flurry_of_claws");
 }