Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full support for PHP 8.1: Update preg_split() default $limit argument #101

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Full support for PHP 8.1: Update preg_split() default $limit argument #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
277fcdf
Update preg_split() default $limit argument
cdosoftei Jan 19, 2022
009f391
PHP 8.1 CI/PHPUnit update
cdosoftei Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
strategy:
matrix:
php:
- 8.1
- 8.0
- 7.4
- 7.3
Expand Down
3 changes: 2 additions & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
bootstrap="vendor/autoload.php"
colors="true"
cacheResult="false">
cacheResult="false"
convertDeprecationsToExceptions="true">
<testsuites>
<testsuite name="Stdio React Test Suite">
<directory>./tests/</directory>
Expand Down
2 changes: 1 addition & 1 deletion src/Readline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ public function strwidth($str)
*/
private function strsplit($str)
{
return preg_split('//u', $str, null, PREG_SPLIT_NO_EMPTY);
return preg_split('//u', $str, -1, PREG_SPLIT_NO_EMPTY);
}

/**
Expand Down