Merge pull request #101 from cdosoftei/main

Full support for PHP 8.1: Update preg_split() default $limit argument
clue · Jan 26, 2022 · 82d80ee · 82d80ee
2 parents 762ba8c + 009f391
commit 82d80ee
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,6 +11,7 @@ jobs:
     strategy:
       matrix:
         php:
+          - 8.1
           - 8.0
           - 7.4
           - 7.3

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -5,7 +5,8 @@
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          colors="true"
-         cacheResult="false">
+         cacheResult="false"
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="Stdio React Test Suite">
             <directory>./tests/</directory>

diff --git a/src/Readline.php b/src/Readline.php
@@ -938,7 +938,7 @@ public function strwidth($str)
      */
     private function strsplit($str)
     {
-        return preg_split('//u', $str, null, PREG_SPLIT_NO_EMPTY);
+        return preg_split('//u', $str, -1, PREG_SPLIT_NO_EMPTY);
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,7 @@ jobs: @@
         strategy:
           matrix:
             php:
+              - 8.1
               - 8.0
               - 7.4
               - 7.3
@@ Expand Down @@