Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check K8S007 for TerminationGracePeriodSeconds on StatefulSets #25

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

bryantbiggs
Copy link
Member

Description

  • Add check K8S007 for TerminationGracePeriodSeconds on StatefulSets
  • Correct logic for min_ready_seconds due to default case (0)
  • Fix reporting to ensure K8s005 (pod_topology_distribution) is shown in report output

Motivation and Context

  • Adds new functionality for checking TerminationGracePeriodSeconds on StatefulSets
  • Ensure results are reportedly correctly

Resolves #8

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@bryantbiggs bryantbiggs merged commit ba628a5 into main Feb 23, 2023
@bryantbiggs bryantbiggs deleted the feat/termination-grace-period branch February 23, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[K8S007] pod.Spec.TerminationGracePeriodSeconds > 0 for StatefulSets
1 participant