Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled error when using unescaped special characters in friendly id #142

Closed
DyegoCosta opened this issue Apr 20, 2018 · 2 comments
Closed

Unhandled error when using unescaped special characters in friendly id #142

DyegoCosta opened this issue Apr 20, 2018 · 2 comments

Comments

@DyegoCosta
Copy link

To reproduce, basically add an unescaped character like # to the CloverConnector's friendlyId.

screenshot 2018-04-19 16 37 19

Missing a call to encodeURIComponent when building the WS address.
@david-clover-com
Copy link
Contributor

Thanks @DyegoCosta.

david-clover-com added a commit that referenced this issue Sep 12, 2018
@david-clover-com
Merge pull request #142 from kristalinc/variable-changes
4d7c1bb 
Support for new variable tokens
@david-clover-com
Copy link
Contributor

This has been fixed in the 3.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DyegoCosta @david-clover-com