added two BSP threads, made 11.5 actually 11.5 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. THe MCU should have plenty of unused flash. It probably has
something to do with the way the flash partitions are allocated. I'll take
a look.
James
…On Fri, Nov 29, 2019 at 8:10 AM Adam ***@***.***> wrote:
Added:
- 19, 27 TPI - these threads common in the UK and Australia (and maybe
Japan as "JIS" threads which also follow a 55 degree Whitworth form).
- 5.5, 6mm metric pitch
Changed:
- 11.5 TPI had the same value (110) as 11 TPI, changed to 115.
Notes:
IDE reported a lack of memory when using a debug profile. Possibly used
all the flash for the metric pitch, I can either remove 5.5, 6, or another
pitch, however this makes a complete table for all M profile threads
(though there may be additional TR [30 deg] trapezoidal pitches). It
compiles fine with a release profile.
------------------------------
You can view, comment on, or merge this pull request online at:
#29
Commit Summary
- added two BSP threads, made 11.5 actually 11.5
File Changes
- *M* els-f280049c/Tables.cpp
<https://github.com/clough42/electronic-leadscrew/pull/29/files#diff-0>
(6)
Patch Links:
- https://github.com/clough42/electronic-leadscrew/pull/29.patch
- https://github.com/clough42/electronic-leadscrew/pull/29.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#29?email_source=notifications&email_token=AAZLSHESXTFD6U2NSDTZCPLQWEWFPA5CNFSM4JTAV73KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H45EKYA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZLSHGB36NMD3WA7QTNU3DQWEWFPANCNFSM4JTAV73A>
.
|
clough42
added a commit
that referenced
this pull request
Nov 30, 2019
…lly 11.5 (#32) * added two BSP threads, made 11.5 actually 11.5 * Merge branch 'master' of https://github.com/carneeki/electronic-leadscrew into carneeki-master Fix ram link file to allow for larger thread tables. # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Changed:
Notes:
IDE reported a lack of memory when using a debug profile. Possibly used all the flash for the metric pitch, I can either remove 5.5, 6, or another pitch, however this makes a complete table for all M profile threads (though there may be additional TR [30 deg] trapezoidal pitches). It compiles fine with a release profile.