Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3: getSignedUrl is missing #29

Closed
TillaTheHun0 opened this issue Feb 9, 2022 · 4 comments · Fixed by #45
Closed

s3: getSignedUrl is missing #29

TillaTheHun0 opened this issue Feb 9, 2022 · 4 comments · Fixed by #45
Labels
enhancement New feature or request

Comments

@TillaTheHun0
Copy link
Contributor

I was looking to use getSignedUrl for uploading directly to s3, but didn't see the method in the generated s3 service. I do see it on the s3 service on the aws sdk referenced on main

Am I looking in the wrong place? Thanks for your help!
@TillaTheHun0 TillaTheHun0 mentioned this issue Feb 9, 2022
Merged
@danopia
Copy link
Member

danopia commented Feb 9, 2022 •
edited
Loading

Hey, thanks for writing!

High level, you're not missing anything here. The focus of this library is to provide clients to the AWS APIs, and pre-signing isn't actually an API call so it wasn't really in scope. This was previously brought up in #5. Please note that /x/aws_api isn't the actual AWS SDK.

In that linked discussion, there is a link to an /x/ module just for pre-signing, check out the message here: #5 (comment) and I also have an example of using it with the /x/aws_api credential loader. I used that pre-signing module in another project and it does the trick, albeit with a somewhat narrow API.

In summary, it would be interesting to work pre-signing methods into this module but there's nothing committed or in progress towards this feature at the exact moment. Definitely let me know if the other options work for your needs!

@danopia danopia added the enhancement New feature or request label Feb 10, 2022
@TillaTheHun0
Copy link
Contributor Author

Agh, I missed that issue. Apologies for the dupe. I'll try out the solutions proposed there. Feel free to close this.

@danopia
Copy link
Member

danopia commented Feb 10, 2022 •
edited
Loading

All good! I'd still like to track common requests like these so that I can discover what additional features to work on. In this case, the big dependency for pre-signing is defining an internal API to build signed URLs. It would be worth doing if the other options are lacking for some reason or another, which is the kind of thing you can provide a voice on as a user :)

Regardless, I haven't documented this sort of limitation properly, so either way I have something to do before closing this issue

TillaTheHun0 added a commit to hyper63/hyper-adapter-namespaced-s3 that referenced this issue Feb 11, 2022
@TillaTheHun0
refactor: use separate lib for creating presigned urls
300dbd7 
Based on the response on cloudydeno/deno-aws_api#29
we had to use another method of creating presigned urls.

We followed the recommendation on the above issue and pulled in a lib
specifically for that
@danopia danopia mentioned this issue Feb 25, 2023
Merged
@danopia
Copy link
Member

danopia commented Feb 26, 2023

🚀 This is added in v0.8.0. There is a low-level presigning API and a high-level "extras" module for S3 presigning.

Example usages of both APIs are in this comment:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor of request signing module, adds a presigning method cloudydeno/deno-aws_api
2 participants
@danopia @TillaTheHun0