-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support new generate flag generate_json_str #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyJavaBean
changed the title
🎸 (feat): Go_Options:Support new generate flag generate_json_str
feat: Go_Options:Support new generate flag generate_json_str
Aug 31, 2023
HeyJavaBean
changed the title
feat: Go_Options:Support new generate flag generate_json_str
feat: support new generate flag generate_json_str
Aug 31, 2023
ok,看起来没问题。我再看下怎么配合类似 Hertz.UseJSONLib( easyJson ) 的方式来做 |
感觉要看下这个用法的人多不多。
说来这个需求的人多么? |
不算多,但之前也有个业务线的同学提过。「下一步」可以先做出来把接口留好 |
我来改下,这个口子开出来吧。 |
xiekeyi98
commented
Aug 31, 2023
HeyJavaBean
reviewed
Aug 31, 2023
@HeyJavaBean 大概改了下,PTAL~ 另外 silm 的生成参数是什么样子的? go build && ./thriftgo -o . -g go:json_stringer=true ./test/golang/cases_and_options/thrifttest/a.thrift
好像这个不行⬇️
go build && ./thriftgo -silm -o . -g go:json_stringer=true ./test/golang/cases_and_options/thrifttest/a.thrift |
xiekeyi98
force-pushed
the
dev/keyi_string_json
branch
from
November 29, 2023 09:05
f9f7ca2
to
276afde
Compare
HeyJavaBean
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As #119 said, add new flag
generate_json_string_method
to generate JSON marshal string in String() Method.Motivation and Context
It is useful when we need get the struct JSON string in some situation.
Related Issue
closes #119