feat: path support under windows #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate file generated on the Windows platform was wrong due to filepath.join
…isting file through the command line tool
Codecov ReportBase: 61.99% // Head: 62.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #676 +/- ##
===========================================
+ Coverage 61.99% 62.08% +0.09%
===========================================
Files 212 212
Lines 16408 16408
===========================================
+ Hits 10172 10187 +15
+ Misses 5267 5251 -16
- Partials 969 970 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
joway
reviewed
Nov 28, 2022
| @@ -245,6 +245,7 @@ func (a *Arguments) checkPath() { | |||
| if a.Use != "" { | |||
| a.PackagePrefix = a.Use | |||
| } | |||
| a.PackagePrefix = strings.ReplaceAll(a.PackagePrefix, "\\", "/") | |||
|
支持 windows 的设计可能要配合 thriftgo 一起修改，现在还没开始做，我先 close 下，等这次发版之后再看下吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
实现在windows下的路径支持
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: When using the kitex command-line tool to generate files under the Windows platform, due to the differences in path parsing between different platforms, the package name path in the file will become an incorrect backslash. This pr will deal with this problem.
zh(optional): 在windows平台下利用kitex命令行工具生成文件时，由于不同平台间的路径解析差异，文件中的包名路径会变成错误的反斜杠，本pr将对这一问题进行了处理
Which issue(s) this PR fixes:
fix #469