Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): add more template parameter #854

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Jul 12, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

添加更多的模版参数

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Add more template parameter
zh(optional): 添加更多的模版参数

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners July 12, 2023 11:06
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +4.12 🎉

Comparison is base (819c222) 75.74% compared to head (c17b9b7) 79.87%.

❗ Current head c17b9b7 differs from pull request most recent head f9cbd92. Consider uploading reports for the commit f9cbd92 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #854      +/-   ##
===========================================
+ Coverage    75.74%   79.87%   +4.12%     
===========================================
  Files           97       97              
  Lines         9515     9534      +19     
===========================================
+ Hits          7207     7615     +408     
+ Misses        1858     1420     -438     
- Partials       450      499      +49     
Impacted Files Coverage Δ
pkg/protocol/http1/server.go 74.27% <ø> (+11.59%) ⬆️
pkg/common/test/mock/body_data.go 92.00% <90.00%> (-8.00%) ⬇️
pkg/common/test/mock/network.go 86.02% <100.00%> (+0.20%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the feat/add_more_template_parameter branch from a903a44 to f9cbd92 Compare July 18, 2023 12:25
@FGYFFFF FGYFFFF merged commit 9014502 into develop Jul 19, 2023
@FGYFFFF FGYFFFF deleted the feat/add_more_template_parameter branch July 19, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants