-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize(bytesconv): add support for go1.20 #686
Conversation
@@ -1,15 +1,28 @@ | |||
module github.com/cloudwego/hertz | |||
|
|||
go 1.16 | |||
go 1.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
em... this may be a problem - since we have plenty of projects running under 1.20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
em... this may be a problem - since we have plenty of projects running under 1.20
This is just a precaution, currently LTS supported by go are 1.18-1.20, maybe we can keep this PR open without merging until necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more word, there are still many users using low versions of go and we need to be responsible for them.
For this reason we have not used io
instead of ioutil
and upgraded the x/sys
version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, can I close it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can keep this PR open without merging until necessary.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #686 +/- ##
===========================================
+ Coverage 72.49% 74.28% +1.78%
===========================================
Files 96 100 +4
Lines 9392 9396 +4
===========================================
+ Hits 6809 6980 +171
+ Misses 2154 1985 -169
- Partials 429 431 +2
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Is there any problem that related to current impl with Go1.20? |
|
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
bytesconv 增加 go1.20 的支持
(Optional) More detail description for this PR(en: English/zh: Chinese).
en:
go1.20 provides a truly safe(ish) APIs people can rely on, to ensure that subsequent go versions will not break
b2s/s2b
(no real world examples). refer togolang/go#53003
valyala/fasthttp#1481
zh(optional):
使用 go1.20 提供的可以依赖的 api 去保证后续 go 版本不会破坏
b2s/s2b
(没有真实场景,不急)。参考golang/go#53003
valyala/fasthttp#1481
Which issue(s) this PR fixes: