Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hz): hz generate client #471

Merged
merged 13 commits into from
Dec 21, 2022
Merged

feat(hz): hz generate client #471

merged 13 commits into from
Dec 21, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Dec 8, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

hz 支持生成 hertz client 侧代码

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: hz generates client code for hertz based on IDL
zh(optional): hz 支持生成 hertz client 侧代码

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 69.68% // Head: 69.65% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (9b689d7) compared to base (7895df7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #471      +/-   ##
===========================================
- Coverage    69.68%   69.65%   -0.04%     
===========================================
  Files           93       93              
  Lines         8752     8752              
===========================================
- Hits          6099     6096       -3     
- Misses        2292     2295       +3     
  Partials       361      361              
Impacted Files Coverage Δ
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 275 files.

Valid Invalid Ignored Fixed
271 2 2 0
Click to see the invalid file list
  • cmd/hz/generator/client.go
  • cmd/hz/thrift/thriftgo_util.go

cmd/hz/generator/client.go Show resolved Hide resolved
cmd/hz/thrift/thriftgo_util.go Show resolved Hide resolved
@FGYFFFF FGYFFFF changed the title 【WIP】feat(hz): hz generate client [WIP]feat(hz): hz generate client Dec 12, 2022
@FGYFFFF FGYFFFF requested review from a team as code owners December 14, 2022 07:13
@FGYFFFF FGYFFFF changed the title [WIP]feat(hz): hz generate client feat(hz): hz generate client Dec 14, 2022
Duslia
Duslia previously approved these changes Dec 15, 2022
cmd/hz/protobuf/ast.go Outdated Show resolved Hide resolved
cmd/hz/thrift/ast.go Outdated Show resolved Hide resolved
cmd/hz/thrift/ast.go Outdated Show resolved Hide resolved
cmd/hz/protobuf/ast.go Outdated Show resolved Hide resolved
cmd/hz/app/app.go Outdated Show resolved Hide resolved
@FGYFFFF FGYFFFF merged commit 257685e into develop Dec 21, 2022
@FGYFFFF FGYFFFF deleted the feat/hz_client branch December 21, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants