Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify the entry to set request options #37

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Jun 4, 2022

What type of PR is this?

refactor: unify the entry of setting request options

What this PR does / why we need it (English/Chinese):

en: unify the entry of setting request options to prevent options uninitialized from causing panic
zh: 统一设置 request options 的入口,防止 options 未初始化导致 panic

@Duslia Duslia force-pushed the refactor/client_options branch 5 times, most recently from 80d3160 to f3e2d79 Compare June 6, 2022 06:32
welkeyever
welkeyever previously approved these changes Jun 6, 2022
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Duslia Duslia force-pushed the refactor/client_options branch from 72f5300 to d2d9a28 Compare June 16, 2022 13:12
@welkeyever welkeyever merged commit 043dbe4 into develop Jun 17, 2022
@welkeyever welkeyever deleted the refactor/client_options branch June 17, 2022 07:05
FGYFFFF pushed a commit to FGYFFFF/hertz that referenced this pull request Dec 23, 2022
* [WIP]feat: add pprof example

* tidy & readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants