Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distinguish between global and local transporter #356

Conversation

welkeyever
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

server 区分局部和全局 transporter

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: change transporter of the hertz instance with option will not effect global transporter, vice versa. Avoid potential problems affecting other instances by modifying the transporter.
zh(optional): 修改 hertz 实例的 transporter 不会影响全局默认的 transporter,反之亦然;避免潜在的因为修改 transporter 导致影响到其他实例的问题。

Which issue(s) this PR fixes:

None

@welkeyever welkeyever force-pushed the feat/distinguish_transporter_between_global_and_local branch 2 times, most recently from dc02486 to ec8ee2c Compare November 8, 2022 13:25
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 66.53% // Head: 66.59% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (92d7ff4) compared to base (3f8c34e).
Patch coverage: 70.58% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #356      +/-   ##
===========================================
+ Coverage    66.53%   66.59%   +0.05%     
===========================================
  Files           89       89              
  Lines         8495     8507      +12     
===========================================
+ Hits          5652     5665      +13     
+ Misses        2482     2480       -2     
- Partials       361      362       +1     
Impacted Files Coverage Δ
pkg/common/config/option.go 100.00% <ø> (ø)
pkg/route/engine.go 62.63% <66.66%> (+0.57%) ⬆️
pkg/app/server/option.go 96.63% <100.00%> (ø)
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/route/engine.go Show resolved Hide resolved
@welkeyever welkeyever force-pushed the feat/distinguish_transporter_between_global_and_local branch from ec8ee2c to c13811e Compare November 9, 2022 02:46
@welkeyever welkeyever requested a review from li-jin-gou November 9, 2022 08:55
li-jin-gou
li-jin-gou previously approved these changes Nov 10, 2022
@welkeyever welkeyever force-pushed the feat/distinguish_transporter_between_global_and_local branch from c13811e to a66a93c Compare November 10, 2022 02:42
@welkeyever welkeyever force-pushed the feat/distinguish_transporter_between_global_and_local branch from a66a93c to 0c897d1 Compare November 10, 2022 07:21
@welkeyever welkeyever force-pushed the feat/distinguish_transporter_between_global_and_local branch from 0c897d1 to 92d7ff4 Compare November 10, 2022 07:33
@welkeyever welkeyever merged commit c89d7ac into cloudwego:develop Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants