Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fshandler and related tests #34

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

byene0923
Copy link
Contributor

#32
remove fshandler and related tests

remove fshandler and related tests
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2022

CLA assistant check
All committers have signed the CLA.

@byene0923 byene0923 changed the title remove fshandler and related tests fix:remove fshandler and related tests Jun 2, 2022
@byene0923 byene0923 changed the title fix:remove fshandler and related tests fix: remove fshandler and related tests Jun 2, 2022
@welkeyever
Copy link
Member

ut blocks the check. Please take a look

@byene0923
Copy link
Contributor Author

yes, there are two invalid tests in the context_test.go. I fix them

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@welkeyever welkeyever merged commit 0369d93 into cloudwego:develop Jun 6, 2022
FGYFFFF pushed a commit to FGYFFFF/hertz that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants