Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support errors format for the recovery middleware #304

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

BaiZe1998
Copy link
Contributor

@BaiZe1998 BaiZe1998 commented Oct 17, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

为 recovery 中间件支持用户自定义错误输出格式

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 64.46% // Head: 64.50% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (243f092) compared to base (b4ba993).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 243f092 differs from pull request most recent head 63ff497. Consider uploading reports for the commit 63ff497 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
+ Coverage    64.46%   64.50%   +0.03%     
===========================================
  Files           84       85       +1     
  Lines         8288     8300      +12     
===========================================
+ Hits          5343     5354      +11     
- Misses        2583     2584       +1     
  Partials       362      362              
Impacted Files Coverage Δ
pkg/app/middlewares/server/recovery/option.go 100.00% <100.00%> (ø)
pkg/app/middlewares/server/recovery/recovery.go 86.36% <100.00%> (-0.31%) ⬇️
pkg/common/timer/timer.go 61.90% <0.00%> (-19.05%) ⬇️
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BaiZe1998 BaiZe1998 force-pushed the feat_recovery branch 2 times, most recently from 5de09e4 to b8a65e2 Compare October 17, 2022 15:32
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@li-jin-gou
Copy link
Member

@BaiZe1998 后续可以补充一下 Recoevry 的文档...

@li-jin-gou li-jin-gou merged commit f687dac into cloudwego:develop Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants