Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pkg/common/config): pkg/common/config test coverage #267

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

rogerogers
Copy link
Contributor

@rogerogers rogerogers commented Sep 22, 2022

What type of PR is this?

test: pkg/common/config test coverage increased from 48.4% to 100%

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: pkg/common/config test coverage
zh(optional): 增加pkg/common/config包测试覆盖率

Which issue(s) this PR fixes:

part of #257

@li-jin-gou
Copy link
Member

thanks

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 59.27% // Head: 59.96% // Increases project coverage by +0.68% 🎉

Coverage data is based on head (2bb2f5e) compared to base (ac34fef).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #267      +/-   ##
===========================================
+ Coverage    59.27%   59.96%   +0.68%     
===========================================
  Files           79       79              
  Lines         8150     8150              
===========================================
+ Hits          4831     4887      +56     
+ Misses        2966     2910      -56     
  Partials       353      353              
Impacted Files Coverage Δ
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️
pkg/common/config/request_option.go 100.00% <0.00%> (+23.52%) ⬆️
pkg/common/config/option.go 100.00% <0.00%> (+100.00%) ⬆️
pkg/common/config/client_option.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever
Copy link
Member

最好是能贴一个增加单侧后的覆盖率哈

@rogerogers
Copy link
Contributor Author

最好是能贴一个增加单侧后的覆盖率哈

修改到描述里了。

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!lgtm

@li-jin-gou li-jin-gou merged commit 74d61a3 into cloudwego:develop Sep 23, 2022
@rogerogers rogerogers deleted the feature/test branch September 23, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants