-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pkg/common/config): pkg/common/config test coverage #267
Conversation
thanks |
Codecov ReportBase: 59.27% // Head: 59.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #267 +/- ##
===========================================
+ Coverage 59.27% 59.96% +0.68%
===========================================
Files 79 79
Lines 8150 8150
===========================================
+ Hits 4831 4887 +56
+ Misses 2966 2910 -56
Partials 353 353
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
06ff8ea
to
2bb2f5e
Compare
最好是能贴一个增加单侧后的覆盖率哈 |
修改到描述里了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!lgtm
What type of PR is this?
test: pkg/common/config test coverage increased from 48.4% to 100%
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detail description for this PR(en: English/zh: Chinese).
en: pkg/common/config test coverage
zh(optional): 增加pkg/common/config包测试覆盖率
Which issue(s) this PR fixes:
part of #257