Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same package for self #216

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Aug 29, 2022

What type of PR is this?

fix

What this PR does / why we need it (English/Chinese):

en: Fix the problem of taking different package names for the same package
zh: 修复针对同一个包取不同包名的问题

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 59.12% // Head: 59.11% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0e5c259) compared to base (dc570ba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
- Coverage    59.12%   59.11%   -0.01%     
===========================================
  Files           79       79              
  Lines         8113     8109       -4     
===========================================
- Hits          4797     4794       -3     
+ Misses        2962     2961       -1     
  Partials       354      354              
Impacted Files Coverage Δ
pkg/app/client/client.go 71.42% <100.00%> (-0.80%) ⬇️
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FGYFFFF FGYFFFF force-pushed the fix/same_package_for_self branch from a2df046 to 63ec262 Compare September 1, 2022 10:41
@Duslia Duslia merged commit 0745fe8 into cloudwego:develop Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants