Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deregister failed when service shutdown #208

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: deregister failed when service shutdown #208

merged 1 commit into from
Aug 25, 2022

Conversation

li-jin-gou
Copy link
Member

@li-jin-gou li-jin-gou commented Aug 23, 2022

What type of PR is this?

fix

What this PR does / why we need it (English/Chinese):

  • zh: 修复取消注册失败当服务停止
  • en: fix deregister failed when service shutdown

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #208 (a3ad012) into develop (f02bce2) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

❗ Current head a3ad012 differs from pull request most recent head 6f057f0. Consider uploading reports for the commit 6f057f0 to get more accurate results

@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
- Coverage    59.00%   58.98%   -0.02%     
===========================================
  Files           79       79              
  Lines         8005     8004       -1     
===========================================
- Hits          4723     4721       -2     
- Misses        2933     2934       +1     
  Partials       349      349              
Impacted Files Coverage Δ
pkg/app/server/hertz.go 75.00% <ø> (-2.59%) ⬇️
pkg/route/engine.go 60.25% <0.00%> (-0.78%) ⬇️
pkg/route/tree.go 96.66% <100.00%> (ø)
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/route/engine.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou merged commit 77e42df into cloudwego:develop Aug 25, 2022
@li-jin-gou li-jin-gou deleted the fix/deregister branch September 25, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants