Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: func checkPathValid returns true if the path is valid #205

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

wangbei98
Copy link
Contributor

@wangbei98 wangbei98 commented Aug 21, 2022

What type of PR is this?

optimize

What this PR does / why we need it (English/Chinese):

en: change the default return
zh: 更改默认返回值

Which issue(s) this PR fixes:

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2022

CLA assistant check
All committers have signed the CLA.

@li-jin-gou li-jin-gou changed the title fix:func checkPathValid returns true by default reactor:func checkPathValid returns true by default Aug 22, 2022
@li-jin-gou li-jin-gou changed the title reactor:func checkPathValid returns true by default refactor:func checkPathValid returns true by default Aug 22, 2022
@FGYFFFF
Copy link
Contributor

FGYFFFF commented Aug 22, 2022

修改的原因是啥?

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #205 (a01c1f7) into develop (f02bce2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #205      +/-   ##
===========================================
+ Coverage    59.00%   59.01%   +0.01%     
===========================================
  Files           79       79              
  Lines         8005     8005              
===========================================
+ Hits          4723     4724       +1     
+ Misses        2933     2932       -1     
  Partials       349      349              
Impacted Files Coverage Δ
pkg/route/tree.go 96.66% <100.00%> (ø)
pkg/common/compress/compress.go 80.95% <0.00%> (-2.86%) ⬇️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wangbei98
Copy link
Contributor Author

修改的原因是啥?

默认返回值和函数名不一致
returns “valid” (“true” for checkPathValid) by default

@welkeyever
Copy link
Member

修改的原因是啥?

默认返回值和函数名不一致 returns “valid” (“true” for checkPathValid) by default

感谢贡献~正式merge前,辛苦签署一下cla哈

@wangbei98
Copy link
Contributor Author

wangbei98 commented Aug 23, 2022

signed

@wangbei98 wangbei98 closed this Aug 23, 2022
@wangbei98 wangbei98 reopened this Aug 23, 2022
@welkeyever welkeyever changed the title refactor:func checkPathValid returns true by default optimize: func checkPathValid returns true if the path is valid Aug 24, 2022
@welkeyever welkeyever merged commit 1a3f275 into cloudwego:develop Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants