Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased unit test coverage for pkg/protocol/header_test #1074

Merged
merged 9 commits into from
Mar 8, 2024

Conversation

XiaoYi-byte
Copy link
Contributor

@XiaoYi-byte XiaoYi-byte commented Mar 6, 2024

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

提高pkg/protocol/header_test的测试覆盖率从77.2%到80.9%

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Increased unit test coverage for pkg/protocol/header_test from 77.2% to 80.9%
zh(optional): 提高pkg/protocol/header_test的测试覆盖率从77.2%到80.9%

(Optional) Which issue(s) this PR fixes:

Fixes #257

(Optional) The PR that updates user documentation:

@XiaoYi-byte XiaoYi-byte requested review from a team as code owners March 6, 2024 03:22
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (f91ce33) to head (df48c98).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1074      +/-   ##
===========================================
+ Coverage    82.52%   82.84%   +0.31%     
===========================================
  Files           98       98              
  Lines        10030    10030              
===========================================
+ Hits          8277     8309      +32     
+ Misses        1257     1232      -25     
+ Partials       496      489       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jin-gou
li-jin-gou previously approved these changes Mar 8, 2024
GuangmingLuo
GuangmingLuo previously approved these changes Mar 8, 2024
@XiaoYi-byte XiaoYi-byte dismissed stale reviews from GuangmingLuo and li-jin-gou via df48c98 March 8, 2024 04:13
@GuangmingLuo GuangmingLuo merged commit 81f0c83 into cloudwego:develop Mar 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Request help: Supplementary of Unit Tests
3 participants