Implement support for YAML and JSON codecs for the file lookup #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=========================================
+ Coverage 87.54% 87.65% +0.1%
=========================================
Files 94 94
Lines 6072 6158 +86
=========================================
+ Hits 5316 5398 +82
- Misses 756 760 +4
Continue to review full report at Codecov.
|
phobologic
approved these changes
Apr 8, 2018
| return Base64(result.data) if b64 else result | ||
|
|
||
|
|
||
| def _parameterize_obj(obj): |
There was a problem hiding this comment.
Can we get some docstrings in here?
danielkza
force-pushed
the
lookup-file-yaml-json
branch
from
e4f08c3 to
403a6a4
Compare
|
Rebased and added docstrings to most of the functions. @phobologic |
phobologic
approved these changes
Jul 4, 2018
|
Ahh, issues with a long line from lint. Tried to fix it, but couldn't push to your branch @danielkza - simple fix, can you clean that up and then I'll merge? Thanks! |
danielkza
force-pushed
the
lookup-file-yaml-json
branch
from
403a6a4 to
52b38ef
Compare
|
Rebased and hopefully fixed the warning :) |
|
Looks great, thanks @danielkza |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
…dtools#537) * Implement support for YAML and JSON codecs for the file lookup * Document YAML and JSON codecs for the file lookup * lookups: file: fix linter warning in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.