Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to support ARRAY<PROTO> #239

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix to support ARRAY<PROTO> #239

merged 2 commits into from
Dec 20, 2024

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Dec 19, 2024 •
edited
Loading

This PR fixes the bug that memefish can't parse ARRAY<PROTO>.

  • NamedType is now parsed in parseScalarSchemaType().

Related issues

makenowjust
makenowjust approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you @apstndb and @will-arxed!

@makenowjust makenowjust merged commit 8c62184 into cloudspannerecosystem:main Dec 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makenowjust makenowjust makenowjust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrays of protos aren't supported in DDL
2 participants
@apstndb @makenowjust