Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CALL statement #231

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Implement CALL statement #231

merged 2 commits into from
Dec 19, 2024

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Dec 18, 2024 •
edited
Loading

This PR implements CALL statement.

  • CALL statement is a first neither of query nor DDL nor DML, so it is treated only as ast.Statement.
    • input/statement directory is added.
  • Existing (*Parser).parseCall(), which is used for ast.CallExpr etc., is renamed to (*Parser).parseCallLike() to make more consistent.
  • Currently, CALL is only used for cancel_query, but it is implemented as ZetaSQL compatible for future extension.

Related issues

makenowjust
makenowjust approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@makenowjust makenowjust merged commit 31325dd into cloudspannerecosystem:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makenowjust makenowjust makenowjust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support CALL statement
2 participants
@apstndb @makenowjust