Implement CREATE PLACEMENT statement #194
Conversation
| @@ -2421,6 +2424,18 @@ func (p *Parser) parseAlterDatabase(pos token.Pos) *ast.AlterDatabase { | |||
| } | |||
| } | |||
|
|
|||
| func (p *Parser) parseCreatePlacement(pos token.Pos) *ast.CreatePlacement { | |||
| p.expectKeywordLike("PLACEMENT") | |||
| name := p.parseIdent() | |||
There was a problem hiding this comment.
According to the official doc, the name is enclosed in the backticks. Do we need to address this?a
There was a problem hiding this comment.
I have not tested in the real multi regional Enterprise Plus instance, but I believe the product accepts name without backquotes.
$ gcloud spanner databases ddl update news-international-database
--instance=news-international-instance
--ddl="CREATE PLACEMENT americas
OPTIONS (instance_partition='americas-partition')"
There was a problem hiding this comment.
I see. Another question: there is no possibility of accepting Path as a name?
There was a problem hiding this comment.
It is a global object and all PLACEMENT KEY in all schemas of the database shares the same namespace.
https://cloud.google.com/spanner/docs/schema-and-data-model#named-schemas
For example, INFORMATION_SCHEMA.PLACEMENTS doesn't have a room to have schema information.
https://cloud.google.com/spanner/docs/information-schema#placements
| Column name | Type | Description |
|---|---|---|
| PLACEMENT_NAME | STRING | The name of the placement. |
| IS_DEFAULT | BOOL | A boolean that indicates whether the placement is the default placement. |
This PR implements
CREATE PLACEMENTDDL statement.resolve #165