Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SCHEMA DDL statements #179

Merged

Conversation

apstndb
Copy link
Contributor

@apstndb apstndb commented Oct 27, 2024

This PR implements SCHEMA DDL statements, CREATE SCHEMA and DROP SCHEMA.

Note

The official docs says DROP SCHEMA can target multiple schema names.

DROP SCHEMA schema_name [, ...]

but, it seems not to be true.

spanner> DROP SCHEMA schema1, schema2;
ERROR: rpc error: code = InvalidArgument desc = Error parsing Spanner DDL statement: DROP SCHEMA schema1, schema2 : Syntax error on line 1, column 20: Expecting 'EOF' but found ','

@apstndb apstndb marked this pull request as ready for review October 27, 2024 23:06
Copy link
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makenowjust makenowjust merged commit 98b8bf2 into cloudspannerecosystem:main Oct 29, 2024
2 checks passed
@apstndb apstndb deleted the feature/schema-ddl-statements branch November 5, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants