Support SELECT AS VALUE and SELECT AS typename #122
Conversation
apstndb
changed the title
apstndb
changed the title
apstndb
changed the title
apstndb
force-pushed
the
feature/generalized-select-as
branch
from
60d020c to
b9e8f3c
Compare
|
Rebase to reduce dependency to other branch. |
ast/ast.go
Outdated
| @@ -443,7 +453,8 @@ type Select struct { | |||
| Select token.Pos // position of "select" keyword | |||
|
|
|||
| Distinct bool | |||
| AsStruct bool | |||
| AsStruct bool // deprecated, use As | |||
There was a problem hiding this comment.
I'm not sure this deprecation is necessary. Could we remove it simply?
There was a problem hiding this comment.
Removed ff14fe6
It is because I didn't sure the deprecation policy of memefish.
Current policy: We can change any AST node without breaking change notification because there are no release version.
Is it correct?
There was a problem hiding this comment.
I have no time to maintain codes with some deprecations. Also, we have no plan to publish a major version, so we can easily introduce breaking changes IMO.
There was a problem hiding this comment.
Thank you for answering!
We can make breaking changes to v0.x.y at any time, but the release process itself is a significant effort, so I think the current policy is fine.
This PR add support of
SELECT AS VALUE#97 andSELECT AS typename#89.SELECT AS VALUEhttps://cloud.google.com/spanner/docs/reference/standard-sql/query-syntax#select_as_value
SELECT AS typenamehttps://cloud.google.com/spanner/docs/reference/standard-sql/query-syntax#select_as_typename
They and
SELECT AS STRUCTare generalized asast.SelectAs.Note: This PR depends onrebasedast.NamedTypein #121, so it is needed to rebase after #121 is merged.fix #97