feat(quarantine): add quarantine add/rm command #80

DavidS-cloud · 2022-05-19T14:17:55Z

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd
Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... OK

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd
Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... ERROR
Failed quarantine! (status: 400 - Bad Request)

Detail: You cannot restore a package that's not quarantined.

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯ python -m cloudsmith_cli quarantine add cloudsmith/testing-private/CjUgS7XxKI8j-Nnd
Adding testing-private/CjUgS7XxKI8j-Nnd to quarantine... OK

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯ python -m cloudsmith_cli quarantine add cloudsmith/testing-private/CjUgS7XxKI8j-Nnd
Adding testing-private/CjUgS7XxKI8j-Nnd to quarantine... ERROR
Failed quarantine! (status: 400 - Bad Request)

Detail: You cannot quarantine this package at this point in time.

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd
Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... OK

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd
Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... ERROR
Failed quarantine! (status: 400 - Bad Request)

Detail: You cannot restore a package that's not quarantined.

cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️  (eu-west-1) 
❯

…t had Quarantine enabled

``` cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... OK cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... ERROR Failed quarantine! (status: 400 - Bad Request) Detail: You cannot restore a package that's not quarantined. cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ python -m cloudsmith_cli quarantine add cloudsmith/testing-private/CjUgS7XxKI8j-Nnd Adding testing-private/CjUgS7XxKI8j-Nnd to quarantine... OK cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ python -m cloudsmith_cli quarantine add cloudsmith/testing-private/CjUgS7XxKI8j-Nnd Adding testing-private/CjUgS7XxKI8j-Nnd to quarantine... ERROR Failed quarantine! (status: 400 - Bad Request) Detail: You cannot quarantine this package at this point in time. cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... OK cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ python -m cloudsmith_cli quarantine rm cloudsmith/testing-private/CjUgS7XxKI8j-Nnd Removing testing-private/CjUgS7XxKI8j-Nnd from quarantine... ERROR Failed quarantine! (status: 400 - Bad Request) Detail: You cannot restore a package that's not quarantined. cloudsmith-cli on  SPOCK-360/add-quarantine-cmd [+?⇡] via 🐍 v3.7.2 (.venv) on ☁️ (eu-west-1) ❯ ```

codeclimate · 2022-05-19T14:20:14Z

cloudsmith_cli/cli/commands/quarantine.py

+    return wrapper
+
+
+@main.group(cls=command.AliasGroup, aliases=["qu"])


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-05-19T14:20:14Z

cloudsmith_cli/cli/commands/quarantine.py

+    return add_quarantine(*args, **kwargs)
+
+
+def remove_quarantine(ctx, opts, owner_repo_package, page, page_size):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-05-19T14:20:14Z

cloudsmith_cli/cli/commands/quarantine.py

+    See the help for subcommands for more information on each.
+    """
+
+def add_quarantine(ctx, opts, owner_repo_package, page, page_size):


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-05-19T14:20:14Z

cloudsmith_cli/cli/commands/quarantine.py

+    return add_quarantine(*args, **kwargs)
+
+
+def remove_quarantine(ctx, opts, owner_repo_package, page, page_size):


Function remove_quarantine has 5 arguments (exceeds 4 allowed). Consider refactoring.

codeclimate · 2022-05-19T14:20:14Z

cloudsmith_cli/cli/commands/quarantine.py

+    See the help for subcommands for more information on each.
+    """
+
+def add_quarantine(ctx, opts, owner_repo_package, page, page_size):


Function add_quarantine has 5 arguments (exceeds 4 allowed). Consider refactoring.

DavidS-cloud · 2022-05-19T15:09:17Z

See also #81

MrTam

LGTM, just one small opinion re the qu shorthand; feel free to get overrule though from @lskillen

MrTam · 2022-05-19T15:42:04Z

README.md

@@ -73,6 +73,9 @@ The CLI currently supports the following commands (and sub-commands):
  - `ruby`:                 Push (upload) a new Ruby package upstream.
  - `terraform`:            Push (upload) a new Terraform package upstream.
  - `vagrant`:              Push (upload) a new Vagrant package upstream.
+- `quarantine`|`qu`:      Manage quarantined packages in a repository.


Not 100% sure on the shorthand here...I get it because quarantine is a long word that I spell incorrectly very regularly 😂 But the qu also forms part of quota below. quar maybe?

ah, yeah, that makes sense 😅

Might want to skip the shorthand completly tho: https://www.urbandictionary.com/define.php?term=quar

Haha, yes! 😂

Err 😂 Yeah, only list aliases rather than shorthand (because shorthand is automatically handled by python-click). If you want a cool alias, I'd go for "jail" but otherwise, feel free to move along. :-)

codeclimate · 2022-05-19T15:54:48Z

cloudsmith_cli/cli/commands/quarantine.py

+    return wrapper
+
+
+@main.group(cls=command.AliasGroup, aliases=["block"])


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2022-05-19T15:54:50Z

Code Climate has analyzed commit 9448f54 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2
Duplication	4

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 0.9% (0.0% change).

View more on Code Climate.

DavidS-cloud added 2 commits May 19, 2022 15:16

fix(deps): update requirement for cloudsmith-api to first version tha…

3440872

…t had Quarantine enabled

codeclimate bot reviewed May 19, 2022

View reviewed changes

docs: add README entry for new command

fadd9ba

DavidS-cloud force-pushed the SPOCK-360/add-quarantine-cmd branch 2 times, most recently from 54a7e9d to fadd9ba Compare May 19, 2022 15:04

DavidS-cloud added 4 commits May 19, 2022 16:15

chore: black reformats

a34e389

chore: flake8

5838278

chore: isort

1ca153a

chore: isort oops

1e37508

MrTam approved these changes May 19, 2022

View reviewed changes

fix(block): change shorthand to avoid overlap with quota

9448f54

codeclimate bot reviewed May 19, 2022

View reviewed changes

DavidS-cloud merged commit 08b887f into master May 19, 2022

DavidS-cloud deleted the SPOCK-360/add-quarantine-cmd branch May 19, 2022 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(quarantine): add quarantine add/rm command #80

feat(quarantine): add quarantine add/rm command #80

DavidS-cloud commented May 19, 2022

codeclimate bot May 19, 2022

codeclimate bot May 19, 2022

codeclimate bot May 19, 2022

codeclimate bot May 19, 2022

codeclimate bot May 19, 2022

DavidS-cloud commented May 19, 2022

MrTam left a comment

MrTam May 19, 2022

DavidS-cloud May 19, 2022

MrTam May 19, 2022

lskillen May 19, 2022

codeclimate bot May 19, 2022

codeclimate bot commented May 19, 2022

		return wrapper


		@main.group(cls=command.AliasGroup, aliases=["qu"])

		return add_quarantine(args, *kwargs)


		def remove_quarantine(ctx, opts, owner_repo_package, page, page_size):

feat(quarantine): add quarantine add/rm command #80

feat(quarantine): add quarantine add/rm command #80

Conversation

DavidS-cloud commented May 19, 2022

codeclimate bot May 19, 2022

Choose a reason for hiding this comment

codeclimate bot May 19, 2022

Choose a reason for hiding this comment

codeclimate bot May 19, 2022

Choose a reason for hiding this comment

codeclimate bot May 19, 2022

Choose a reason for hiding this comment

codeclimate bot May 19, 2022

Choose a reason for hiding this comment

DavidS-cloud commented May 19, 2022

MrTam left a comment

Choose a reason for hiding this comment

MrTam May 19, 2022

Choose a reason for hiding this comment

DavidS-cloud May 19, 2022

Choose a reason for hiding this comment

MrTam May 19, 2022

Choose a reason for hiding this comment

lskillen May 19, 2022

Choose a reason for hiding this comment

codeclimate bot May 19, 2022

Choose a reason for hiding this comment

codeclimate bot commented May 19, 2022